Irsa 3460 port to debian10 #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smonkewitz
approved these changes
Jan 5, 2021
smonkewitz
left a comment
smonkewitz
left a comment
There was a problem hiding this comment.
👍
If the sleep calls can be removed form the demo files, I think that would be an improvement.
json_demo/json_demo.cpp
Outdated
| write_addrs(file_name, addrs); | ||
|
|
||
| std::chrono::seconds dura(1); | ||
| std::this_thread::sleep_for(dura); |
Author
There was a problem hiding this comment.
Per the commit comment:
json_demo.cpp, json_map_demo.cpp, json_headers_only_demo.cpp: Added "sleep()" call
intended to prevent unreproducible "read" failures.
I'll remove the sleep statements now and see if I still see those failures.
|
(Again, it looks like we probably shouldn't merge until we are ready to switch development to Debian 10 entirely). |
The port was complicated by changes to boost::spirit which I was unable to pinpoint.
json5_parser_reader_template.h: new_identifier() now trims trailing whitespace no
longer trimmed by boost::spirit parser.
json5_parser_reader_test.cpp:
test_reading(): reformatted and added test case.
check_reading_arrays(): added "unget()" to accommodate change to boost::spirit.
json5_parser_value_test.cpp: tweaked to accommodate change to boost::assign::list_of().
json_demo.cpp, json_map_demo.cpp, json_headers_only_demo.cpp: Added "sleep()" call
intended to prevent unreproducible "read" failures.
Added print statements to test source files.
wscript: Replaced "-Ofast" with "-O3".
judith-ipac
force-pushed
the
IRSA-3460_Port_To_Debian10
branch
from
cbb1659 to
baf3bdd
Compare
Author
|
Hi, Angela. Serge reviewed this branch (Port to Debian 10) but didn't approve because we weren't ready to merge to master. Could you please approve it? The Debian 11 branch is based on this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.